TextBlock isSubtle property #3
Labels
Comments
jwoo-msft
added a commit
that referenced
this issue
Dec 19, 2017
* markdown delimiter phase 1 * Added MarkDownParser and updated .sln * Implemented upto rule 14 * Implemented upto Rule 16 * emphasis MarkDown Dev Complete * Spacing Check & Flushed Unitest for MD * Added more test cases and handle edge case * Added CR fixes * CR Fix * CR Fix * CR Fix * CR Fix * rebase #1 * rebase #2 * Finished State Machine for Link * clean-up emphasis code to increase readability * Markdown Refactored * separated and refactored code generation * Refactoring Done for Emphasis * link in work * tokenizer refactoring done * Link Almost Finshed * MarkDown Link Dev Complete * MarkDown Rewrite #3 * MarkDown Link is finished / Refactored Code * list added * list almost done * List added / CR fixes * CR changes * CR fix added * CR changes * CR fix * revert AdaptiveCars.sln changes
almedina-ms
added a commit
that referenced
this issue
Feb 26, 2018
# This is the 1st commit message: Fix unit tests due to new change Rename TextBlockText and TextSection class Renames function to comply with new class name Fix locale imbuing error Fix unit tests Re Add files with changed names to project Rename java files from object model modification Changes jsonobject for jsonvalue in action.submit data (#1092) Jwoo/ios perf experimental (#1124) * disabled html rendering on attributed string * made utilization of concurrent queue * fix verfication done * Finished Async Image D/L & Process * making text block rendering asyncronous * disabled used of expensive api call * Async NSAttributedText, removed expensive sys call * dev complete * code clean up * Finished Code Clean-Up * fixed minor naming mix-up * CR comments added * Fixed comments * CR comments Convert HTML in TextBlocks to Xaml runs (#1113) Convert HTML in TextBlocks to Xaml runs # This is the commit message #2: Add support for inline actions to Outlook container (#1136) * Support for explicit padding and background color in containers * Replace Container.backgroundColor with Container.colorPalette * Bug fix and HostConfig touch ups * Automatic padding (unfinished) * Use named padding instead of physical ones * Fix after merge from master * Padding all around or no padding at all for containers with background * Bug fixes * Refresh paddings when element visibility changes * Add explicit image sizing support * Bug fix * Remove explicit padding support Add option to enable automatic padding Add way to turn on beta features in visualizer * Rename colorPalette into style (of type ContainerStyle) * Small refactoring of separator handling * Another small refactoring * Apply auto padding to separators * Bug fix * Small tweak * Add support for custom link handling Add support for anchor styling * Content should always bleed into card's padding * Fix checkbox and radio buttons not clipping properly * Small fix to visualizer * Support per-card host config Plus small bug fix * Minor refactor * Change the way auto-sized columns behave Plus fix default values for ToggleInput * Small fix for the height property when set to auto * [TypeScript] Add explicit padding capability for Container * Fix inline ShowCard expansion with explicit padding * Remove obsolete Container.bleed property * Add explicit padding support for ColumnSet * Add support for inline actions to Outlook container onAnchorClicked event now takes a card object as a parameter # This is the commit message #3: Move maps to function static rather than global (#1135) # This is the commit message #4: fixed an issue of incorrect binding event handler inside forloop (#1138) # This is the commit message #5: Bug: ImageSetConfig - max image height (#1129) * maxImageHeight json parsing fix * ImageSetConfig unit test is added # This is the commit message #6: Eschavez/layout fixes (#1117) * Fixing buttons being shown in different rows. HorizontalFlowLayout works now * spacing and separation are now applied to all read-only and input renderers * Do not add space to the first element of a view * Multi-line text block fix * Setting the padding to root LinearLayout of card * Nit: remove 2 new line # This is the commit message #7: implemented input dismiss view (#1142) * implemented input dismiss view * Fixed CR # This is the commit message #8: Jwoo/ios custom rendering (#1143) * Extended Custom Rendering to all object types * Fix Before CR * Chages for CR # This is the commit message #9: Jwoo/ios seperator (#1145) * implemented Font * seperator color is read from host config * CR Fix * Fix after CR comment # This is the commit message #10: Fixed the condition to fall back to default value of font family. (#1147) # This is the commit message #11: iOS: Show image with higher resolution (#1149) * Do not down-sample image. Specify width/height constraints to image view. * small refactoring # This is the commit message #12: Removed marked-schema from repo, which seems wrongly added. (#1148) # This is the commit message #13: fixes cases interger is being truncated (#1146) # This is the commit message #14: iOS: Respect font weight to render text in lighter weight (#1159) * Introduced getTextBlockFontWeight. Renamed getTextBlockTextWeight to getTextStrokeWidthForWeight to represent its real functionality. * No longer specify stroke width to TextBlock, relying fully on font weight specified otherwise. # This is the commit message #15: Jwoo/ios sample app (#1156) * work-in-progress * update * resized scrollview area * readjusted look of sample and update imagerenderer * CR fixes
almedina-ms
added a commit
that referenced
this issue
Mar 1, 2018
* Updating the android renderer * Column set is fixed. Switched to using LinearLayout with weights instead of GridLayout. Images are scaling for some reason when they shouldn't be * Images are now being sized correctly with correct horizontal alignment * Add lang and region tag for json parsing * Add enums for language and region * Add validation for setting language to TextBlock and Container * Add locale imbuing to date stream * Add method to propagate language to elements inside container * Removing the weight in columns for factset. Text now goes through the Markdown parser before rendering. Also publishing updates from running SWIG. * Fixing images not loading and auto sizing taking up entire height of original image * Fixing the newline that gets added when using HTML for text block * Nits * Changes parsed text from string to wstring * Add conversion method for WString * Add testing, may have to escape the characters * Fixes compilation error * Adds testing for long and short formats in multiple languages * Removes region tag * Removes Region from enums * Add lang and region tag for json parsing * Add enums for language and region * Add validation for setting language to TextBlock and Container * Add locale imbuing to date stream * Add method to propagate language to elements inside container * Changes parsed text from string to wstring * Add conversion method for WString * Add testing, may have to escape the characters * Fixes compilation error * Adds testing for long and short formats in multiple languages * Removes region tag * Removes Region from enums * Adds methods to propagate language between cards * Add u16string conversion method * Fixes unmerged file * Fix java renderer issue and add new data types * Replace dynamic_pointer_cast for static_pointer_cast * Separates textblock string into a new class, removes locales * Add almost functional example on how to parse date for uwp * Adds datetime parsing * Separates TextSection into its own file * Fixes compilation erro * Removes duplicate TextSection class * Fixing issues with SWIG not generating java files correctly. * Working version for android completed * Removes unecessary conversion to wstring and back * Adds validation for getting date and time values and removes duplicate code * Fix android compilation error and copy-paste bug * Add changes to android layer * Add new files to compilation * Fix tests for date conversion delegation * Change default language for locale * Add validation to avoid placing emty strings * Add new files to project files * Move time generation to shared model * # This is a combination of 15 commits. # This is the 1st commit message: Fix unit tests due to new change Rename TextBlockText and TextSection class Renames function to comply with new class name Fix locale imbuing error Fix unit tests Re Add files with changed names to project Rename java files from object model modification Changes jsonobject for jsonvalue in action.submit data (#1092) Jwoo/ios perf experimental (#1124) * disabled html rendering on attributed string * made utilization of concurrent queue * fix verfication done * Finished Async Image D/L & Process * making text block rendering asyncronous * disabled used of expensive api call * Async NSAttributedText, removed expensive sys call * dev complete * code clean up * Finished Code Clean-Up * fixed minor naming mix-up * CR comments added * Fixed comments * CR comments Convert HTML in TextBlocks to Xaml runs (#1113) Convert HTML in TextBlocks to Xaml runs # This is the commit message #2: Add support for inline actions to Outlook container (#1136) * Support for explicit padding and background color in containers * Replace Container.backgroundColor with Container.colorPalette * Bug fix and HostConfig touch ups * Automatic padding (unfinished) * Use named padding instead of physical ones * Fix after merge from master * Padding all around or no padding at all for containers with background * Bug fixes * Refresh paddings when element visibility changes * Add explicit image sizing support * Bug fix * Remove explicit padding support Add option to enable automatic padding Add way to turn on beta features in visualizer * Rename colorPalette into style (of type ContainerStyle) * Small refactoring of separator handling * Another small refactoring * Apply auto padding to separators * Bug fix * Small tweak * Add support for custom link handling Add support for anchor styling * Content should always bleed into card's padding * Fix checkbox and radio buttons not clipping properly * Small fix to visualizer * Support per-card host config Plus small bug fix * Minor refactor * Change the way auto-sized columns behave Plus fix default values for ToggleInput * Small fix for the height property when set to auto * [TypeScript] Add explicit padding capability for Container * Fix inline ShowCard expansion with explicit padding * Remove obsolete Container.bleed property * Add explicit padding support for ColumnSet * Add support for inline actions to Outlook container onAnchorClicked event now takes a card object as a parameter # This is the commit message #3: Move maps to function static rather than global (#1135) # This is the commit message #4: fixed an issue of incorrect binding event handler inside forloop (#1138) # This is the commit message #5: Bug: ImageSetConfig - max image height (#1129) * maxImageHeight json parsing fix * ImageSetConfig unit test is added # This is the commit message #6: Eschavez/layout fixes (#1117) * Fixing buttons being shown in different rows. HorizontalFlowLayout works now * spacing and separation are now applied to all read-only and input renderers * Do not add space to the first element of a view * Multi-line text block fix * Setting the padding to root LinearLayout of card * Nit: remove 2 new line # This is the commit message #7: implemented input dismiss view (#1142) * implemented input dismiss view * Fixed CR # This is the commit message #8: Jwoo/ios custom rendering (#1143) * Extended Custom Rendering to all object types * Fix Before CR * Chages for CR # This is the commit message #9: Jwoo/ios seperator (#1145) * implemented Font * seperator color is read from host config * CR Fix * Fix after CR comment # This is the commit message #10: Fixed the condition to fall back to default value of font family. (#1147) # This is the commit message #11: iOS: Show image with higher resolution (#1149) * Do not down-sample image. Specify width/height constraints to image view. * small refactoring # This is the commit message #12: Removed marked-schema from repo, which seems wrongly added. (#1148) # This is the commit message #13: fixes cases interger is being truncated (#1146) # This is the commit message #14: iOS: Respect font weight to render text in lighter weight (#1159) * Introduced getTextBlockFontWeight. Renamed getTextBlockTextWeight to getTextStrokeWidthForWeight to represent its real functionality. * No longer specify stroke width to TextBlock, relying fully on font weight specified otherwise. # This is the commit message #15: Jwoo/ios sample app (#1156) * work-in-progress * update * resized scrollview area * readjusted look of sample and update imagerenderer * CR fixes * Fix objectmodel_wrap after squash * Fix comments from PR * Fix PR comments Fix android version due to changes in shared model Fix build error for shared model fixed container style issue (#1162) * fixed container style issue * adding forgotten files back added default values for choice set (#1167) * added default values for choice set * CR fixes Make the timezone during for the DateTime tests always Pacific, since tests assume that that is the current timezone. (#1158) Eschavez/androidActions (#1141) * Improving the pop up dialog in sample app. * Overriding button styles that get applied to card * Using single action handler for submit, openUrl, and showCard. Also removing unused imports. * Re-run swig to fix build failures, and inline show cards now works! * First attempt at converting dp to px size * Weight is allowed to be a float * re-enabling padding as a size for card element. Also fixing issue with TextBlock adding new line and ignoring the markdown tags * Supporting select action. * setTextSize uses sp so no need to convert * Updating sample so it does not render the card twice * Nits Add the google source to properly download gradle on a build machine (#1175) [TypeScript] Add lang support (#1177) iOS: Support borderColor/borderThickness for Container (#1150) * Parse borderColor from host config. * Set borderColor at initWithStyle * Parse borderThickness * Set borderWidth * Fix for a test break introduced from outside * Added disclaimer on the experimental properties * Changed the type of border thickness to uint. Fix Xamarin Android build break caused by changes in ActionHandler (#1180) Change to return FrameworkElement instead of UIElement (#1183) Change to return FrameworkElement instead of UIElement Adding Type string to BaseCardElement and BaseActionElement (#1186) * Adding style string to BaseCardElement. Also re-ran swig which generated border color and thickness methods for container style. * Adding type string to base action element * Nit: removing extra lines
paulcam206
added a commit
that referenced
this issue
May 11, 2021
Adds editor, error display, et. al.
paulcam206
added a commit
that referenced
this issue
May 18, 2021
Adds editor, error display, et. al.
TemoeBOUISSOU
pushed a commit
to TemoeBOUISSOU/AdaptiveCards
that referenced
this issue
Jun 7, 2021
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this issue
May 8, 2024
* markdown delimiter phase 1 * Added MarkDownParser and updated .sln * Implemented upto rule 14 * Implemented upto Rule 16 * emphasis MarkDown Dev Complete * Spacing Check & Flushed Unitest for MD * Added more test cases and handle edge case * Added CR fixes * CR Fix * CR Fix * CR Fix * CR Fix * rebase microsoft#1 * rebase microsoft#2 * Finished State Machine for Link * clean-up emphasis code to increase readability * Markdown Refactored * separated and refactored code generation * Refactoring Done for Emphasis * link in work * tokenizer refactoring done * Link Almost Finshed * MarkDown Link Dev Complete * MarkDown Rewrite microsoft#3 * MarkDown Link is finished / Refactored Code * list added * list almost done * List added / CR fixes * CR changes * CR fix added * CR changes * CR fix * revert AdaptiveCars.sln changes
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this issue
May 8, 2024
* Updating the android renderer * Column set is fixed. Switched to using LinearLayout with weights instead of GridLayout. Images are scaling for some reason when they shouldn't be * Images are now being sized correctly with correct horizontal alignment * Add lang and region tag for json parsing * Add enums for language and region * Add validation for setting language to TextBlock and Container * Add locale imbuing to date stream * Add method to propagate language to elements inside container * Removing the weight in columns for factset. Text now goes through the Markdown parser before rendering. Also publishing updates from running SWIG. * Fixing images not loading and auto sizing taking up entire height of original image * Fixing the newline that gets added when using HTML for text block * Nits * Changes parsed text from string to wstring * Add conversion method for WString * Add testing, may have to escape the characters * Fixes compilation error * Adds testing for long and short formats in multiple languages * Removes region tag * Removes Region from enums * Add lang and region tag for json parsing * Add enums for language and region * Add validation for setting language to TextBlock and Container * Add locale imbuing to date stream * Add method to propagate language to elements inside container * Changes parsed text from string to wstring * Add conversion method for WString * Add testing, may have to escape the characters * Fixes compilation error * Adds testing for long and short formats in multiple languages * Removes region tag * Removes Region from enums * Adds methods to propagate language between cards * Add u16string conversion method * Fixes unmerged file * Fix java renderer issue and add new data types * Replace dynamic_pointer_cast for static_pointer_cast * Separates textblock string into a new class, removes locales * Add almost functional example on how to parse date for uwp * Adds datetime parsing * Separates TextSection into its own file * Fixes compilation erro * Removes duplicate TextSection class * Fixing issues with SWIG not generating java files correctly. * Working version for android completed * Removes unecessary conversion to wstring and back * Adds validation for getting date and time values and removes duplicate code * Fix android compilation error and copy-paste bug * Add changes to android layer * Add new files to compilation * Fix tests for date conversion delegation * Change default language for locale * Add validation to avoid placing emty strings * Add new files to project files * Move time generation to shared model * # This is a combination of 15 commits. # This is the 1st commit message: Fix unit tests due to new change Rename TextBlockText and TextSection class Renames function to comply with new class name Fix locale imbuing error Fix unit tests Re Add files with changed names to project Rename java files from object model modification Changes jsonobject for jsonvalue in action.submit data (microsoft#1092) Jwoo/ios perf experimental (microsoft#1124) * disabled html rendering on attributed string * made utilization of concurrent queue * fix verfication done * Finished Async Image D/L & Process * making text block rendering asyncronous * disabled used of expensive api call * Async NSAttributedText, removed expensive sys call * dev complete * code clean up * Finished Code Clean-Up * fixed minor naming mix-up * CR comments added * Fixed comments * CR comments Convert HTML in TextBlocks to Xaml runs (microsoft#1113) Convert HTML in TextBlocks to Xaml runs # This is the commit message microsoft#2: Add support for inline actions to Outlook container (microsoft#1136) * Support for explicit padding and background color in containers * Replace Container.backgroundColor with Container.colorPalette * Bug fix and HostConfig touch ups * Automatic padding (unfinished) * Use named padding instead of physical ones * Fix after merge from master * Padding all around or no padding at all for containers with background * Bug fixes * Refresh paddings when element visibility changes * Add explicit image sizing support * Bug fix * Remove explicit padding support Add option to enable automatic padding Add way to turn on beta features in visualizer * Rename colorPalette into style (of type ContainerStyle) * Small refactoring of separator handling * Another small refactoring * Apply auto padding to separators * Bug fix * Small tweak * Add support for custom link handling Add support for anchor styling * Content should always bleed into card's padding * Fix checkbox and radio buttons not clipping properly * Small fix to visualizer * Support per-card host config Plus small bug fix * Minor refactor * Change the way auto-sized columns behave Plus fix default values for ToggleInput * Small fix for the height property when set to auto * [TypeScript] Add explicit padding capability for Container * Fix inline ShowCard expansion with explicit padding * Remove obsolete Container.bleed property * Add explicit padding support for ColumnSet * Add support for inline actions to Outlook container onAnchorClicked event now takes a card object as a parameter # This is the commit message microsoft#3: Move maps to function static rather than global (microsoft#1135) # This is the commit message microsoft#4: fixed an issue of incorrect binding event handler inside forloop (microsoft#1138) # This is the commit message microsoft#5: Bug: ImageSetConfig - max image height (microsoft#1129) * maxImageHeight json parsing fix * ImageSetConfig unit test is added # This is the commit message microsoft#6: Eschavez/layout fixes (microsoft#1117) * Fixing buttons being shown in different rows. HorizontalFlowLayout works now * spacing and separation are now applied to all read-only and input renderers * Do not add space to the first element of a view * Multi-line text block fix * Setting the padding to root LinearLayout of card * Nit: remove 2 new line # This is the commit message microsoft#7: implemented input dismiss view (microsoft#1142) * implemented input dismiss view * Fixed CR # This is the commit message microsoft#8: Jwoo/ios custom rendering (microsoft#1143) * Extended Custom Rendering to all object types * Fix Before CR * Chages for CR # This is the commit message microsoft#9: Jwoo/ios seperator (microsoft#1145) * implemented Font * seperator color is read from host config * CR Fix * Fix after CR comment # This is the commit message microsoft#10: Fixed the condition to fall back to default value of font family. (microsoft#1147) # This is the commit message microsoft#11: iOS: Show image with higher resolution (microsoft#1149) * Do not down-sample image. Specify width/height constraints to image view. * small refactoring # This is the commit message microsoft#12: Removed marked-schema from repo, which seems wrongly added. (microsoft#1148) # This is the commit message microsoft#13: fixes cases interger is being truncated (microsoft#1146) # This is the commit message microsoft#14: iOS: Respect font weight to render text in lighter weight (microsoft#1159) * Introduced getTextBlockFontWeight. Renamed getTextBlockTextWeight to getTextStrokeWidthForWeight to represent its real functionality. * No longer specify stroke width to TextBlock, relying fully on font weight specified otherwise. # This is the commit message microsoft#15: Jwoo/ios sample app (microsoft#1156) * work-in-progress * update * resized scrollview area * readjusted look of sample and update imagerenderer * CR fixes * Fix objectmodel_wrap after squash * Fix comments from PR * Fix PR comments Fix android version due to changes in shared model Fix build error for shared model fixed container style issue (microsoft#1162) * fixed container style issue * adding forgotten files back added default values for choice set (microsoft#1167) * added default values for choice set * CR fixes Make the timezone during for the DateTime tests always Pacific, since tests assume that that is the current timezone. (microsoft#1158) Eschavez/androidActions (microsoft#1141) * Improving the pop up dialog in sample app. * Overriding button styles that get applied to card * Using single action handler for submit, openUrl, and showCard. Also removing unused imports. * Re-run swig to fix build failures, and inline show cards now works! * First attempt at converting dp to px size * Weight is allowed to be a float * re-enabling padding as a size for card element. Also fixing issue with TextBlock adding new line and ignoring the markdown tags * Supporting select action. * setTextSize uses sp so no need to convert * Updating sample so it does not render the card twice * Nits Add the google source to properly download gradle on a build machine (microsoft#1175) [TypeScript] Add lang support (microsoft#1177) iOS: Support borderColor/borderThickness for Container (microsoft#1150) * Parse borderColor from host config. * Set borderColor at initWithStyle * Parse borderThickness * Set borderWidth * Fix for a test break introduced from outside * Added disclaimer on the experimental properties * Changed the type of border thickness to uint. Fix Xamarin Android build break caused by changes in ActionHandler (microsoft#1180) Change to return FrameworkElement instead of UIElement (microsoft#1183) Change to return FrameworkElement instead of UIElement Adding Type string to BaseCardElement and BaseActionElement (microsoft#1186) * Adding style string to BaseCardElement. Also re-ran swig which generated border color and thickness methods for container style. * Adding type string to base action element * Nit: removing extra lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Should we make subtle a textColor semantic value versus the isSubtle property. Is it useful to combine them?
{ textColor: "warning", "isSubtle": true }The text was updated successfully, but these errors were encountered: